Skip to content

Add remote_decode to remote_utils #10898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Mar 2, 2025
Merged

Add remote_decode to remote_utils #10898

merged 40 commits into from
Mar 2, 2025

Conversation

hlky
Copy link
Contributor

@hlky hlky commented Feb 25, 2025

What does this PR do?

https://huggingface.co/blog/remote_vae

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hlky hlky requested a review from sayakpaul February 25, 2025 06:44
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left some comments.

@hlky
Copy link
Contributor Author

hlky commented Feb 25, 2025

Interface is unchanged for integrations of existing remote_decode method, main changes are docstrings and introducing return_type to support some other use cases.

@sayakpaul
Copy link
Member

@hlky WDYT about these changes https://github.com/sayakpaul/diffusers/pull/1/files?

@hlky
Copy link
Contributor Author

hlky commented Feb 25, 2025

@sayakpaul LGTM, feel free to push to the branch

@hlky
Copy link
Contributor Author

hlky commented Feb 28, 2025

@bot /style

Copy link
Contributor

Style fixes have been applied. View the workflow run here.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for merging but it would be good to have a test suite for the method for folks to understand how this should be used.

@hlky
Copy link
Contributor Author

hlky commented Feb 28, 2025

Let's add the test suite before merge, best to make sure everything works. I'll need to temporarily create separate endpoints with the new containers, we'll let the tests run with those, merge, replace the existing containers, push the blog, and finally update the endpoint urls in our tests.

@hlky
Copy link
Contributor Author

hlky commented Mar 1, 2025

@bot /style

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Style fixes have been applied. View the workflow run here.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments from my side. LMK if they make sense. Additionally, should these tests be nightly?

hlky and others added 2 commits March 1, 2025 17:03
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@hlky
Copy link
Contributor Author

hlky commented Mar 1, 2025

@bot /style

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Style fixes have been applied. View the workflow run here.


---

## Why use Hybrid Inference?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so here basically we listed the type of end points we offer, I think we can create a section for that later
for a "Why use ...?" section, let's highlight user benefits (I think currently the "key benefits" section is intended for)


## Key Benefits

- 🚀 **Reduced Requirements:** Access powerful models without expensive hardware.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just reduced requirement though, the key is that we don't sacrificing quality/performance and also cost-efficient (currently free)

- 🎯 **Diverse Use Cases:** Fully compatible with Diffusers 🧨 and the wider community.
- 🔧 **Developer-Friendly:** Simple requests, fast responses.

---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a section to showcase Real-World Use cases! we can link to comfy nodes etc

@hlky hlky merged commit fc4229a into huggingface:main Mar 2, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants