-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add remote_decode
to remote_utils
#10898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left some comments.
Interface is unchanged for integrations of existing |
@hlky WDYT about these changes https://github.com/sayakpaul/diffusers/pull/1/files? |
@sayakpaul LGTM, feel free to push to the branch |
@bot /style |
Style fixes have been applied. View the workflow run here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for merging but it would be good to have a test suite for the method for folks to understand how this should be used.
Let's add the test suite before merge, best to make sure everything works. I'll need to temporarily create separate endpoints with the new containers, we'll let the tests run with those, merge, replace the existing containers, push the blog, and finally update the endpoint urls in our tests. |
@bot /style |
Style fixes have been applied. View the workflow run here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments from my side. LMK if they make sense. Additionally, should these tests be nightly?
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@bot /style |
Style fixes have been applied. View the workflow run here. |
|
||
--- | ||
|
||
## Why use Hybrid Inference? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so here basically we listed the type of end points we offer, I think we can create a section for that later
for a "Why use ...?" section, let's highlight user benefits (I think currently the "key benefits" section is intended for)
|
||
## Key Benefits | ||
|
||
- 🚀 **Reduced Requirements:** Access powerful models without expensive hardware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not just reduced requirement though, the key is that we don't sacrificing quality/performance and also cost-efficient (currently free)
- 🎯 **Diverse Use Cases:** Fully compatible with Diffusers 🧨 and the wider community. | ||
- 🔧 **Developer-Friendly:** Simple requests, fast responses. | ||
|
||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a section to showcase Real-World Use cases! we can link to comfy nodes etc
What does this PR do?
https://huggingface.co/blog/remote_vae
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.