-
Notifications
You must be signed in to change notification settings - Fork 6.1k
SkyReels Hunyuan T2V & I2V #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkyReels Hunyuan T2V & I2V #10837
Conversation
@@ -325,7 +325,7 @@ def encode_prompt( | |||
) | |||
|
|||
if pooled_prompt_embeds is None: | |||
if prompt_2 is None and pooled_prompt_embeds is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pooled_prompt_embeds
can never be None
otherwise we'll error out in transformer. Change not required for integration but we should do it anyway (perhaps in separate PR if not here)
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thank you!
Pretty heavy models to run locally. I hope will be some hints on how to run it on consumer hardware? |
int4 didn't run on 24GB? |
I had to bump torch to get the dynamo working. After that I got int4 working. Thank you @nitinmukesh for the int4 version of the transformer. Is support for Skyworks' A1 (motion transfer) considered? |
Oh... the dynamo part is not required 🫠 I was just benchmarking torch compile with the model and forgot to remove when copy-pasting the minimal snippet. Regarding Skyreels A1, could you open an issue for tracking? Currently, we haven't planned for it due to some other priorities but any community contribution from looking at an open issue would be helpful from the interested folks! |
Also, ideally with group offloading (and possibly combining layerwise upcasting), we have the lowest VRAM requirements (without much generation time overhead) I believe. Currently, we're limited by CPU RAM, but we'll try to improve on that asap :) |
Lol, didn't understand the last part. No worries. In general, if a new model is VRAM intensive and the Diffusers team has knowledge of ways to improve that, please include some hints in the model card. |
Adds support for SkyReels-V1. Also fixes #10768 and overrides #10567
Repo: https://github.com/SkyworkAI/SkyReels-V1
The authors used the diffusers model implementation and created the pipeline themselves, so all credits to them! This is just a quick ctrl c+v
T2V:
I2V:
output.mp4
output_i2v.mp4
cc @asomoza @Langdx @Howe2018