Add pipeline_stable_diffusion_xl_attentive_eraser#10579

Merged

hlky merged 9 commits intohuggingface:mainfrom

Anonym0u3:add-AttentiveEraser

Jan 24, 2025

Contributor

Anonym0u3 commented Jan 14, 2025

What does this PR do?

add pipeline_stable_diffusion_xl_attentive_eraser
#10415
@hlky

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline?
Did you read our philosophy doc (important for complex PRs)?
Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.


          add pipeline_stable_diffusion_xl_attentive_eraser

2e1920e

hlky reviewed

View reviewed changes

Contributor

hlky left a comment

Thanks @Anonym0u3. Could you run make style?

HuggingFaceDocBuilderDev commented Jan 14, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


          add pipeline_stable_diffusion_xl_attentive_eraser_make_style

a2f805d

Contributor Author

Anonym0u3 commented Jan 14, 2025

Hi @hlky , I sincerely apologize for missing the code style check. I have now run black、isort and flake8 tools to check and update the code style. If there are any additional issues or further adjustments needed, please let me know, and I’ll address them promptly.
Additionally can you help me upload the example images here so that I can use the image link in the usage documentation, thanks!

Thanks @Anonym0u3. Could you run make style?

Contributor

hlky commented Jan 14, 2025

We use ruff, generally for contributing we recommend using a venv and doing pip install -e ".[dev]", then there is a Makefile with style, fix-copies etc.

You can also do pip install ruff==0.1.5 then ruff check examples scripts src tests utils benchmarks setup.py --fix --unsafe-fixes.

Can we add the example output to the Hub PR/docs?

Anonym0u3 added 2 commits

January 15, 2025 17:04


          make style and add example output

717e2c7


          make style and add example output

09c0e5c

Contributor Author

Anonym0u3 commented Jan 15, 2025

@hlky Thank you for your detailed instructions! I have successfully run make style as recommended and updated the example output in the documentation.

Anonym0u3 and others added 2 commits

January 16, 2025 22:00


          update Docs

1b47ff7

Co-authored-by: Other Contributor <a457435687@126.com>


          add Oral

72ee35e

Co-authored-by: Other Contributor <a457435687@126.com>

Contributor Author

Anonym0u3 commented Jan 18, 2025

Hi @hlky , I’m excited to share that my paper has been accepted as an Oral presentation at AAAI 2025! To reflect this update, I’ve submitted a new PR with the relevant documentation changes. Please let me know if there are any additional adjustments needed or if you have any feedback on the code. Looking forward to your review!

Anonym0u3 requested a review from hlky

January 24, 2025 11:34


          Merge branch 'main' into add-AttentiveEraser

c2d5b91

hlky approved these changes

View reviewed changes

Contributor

hlky left a comment

Thanks @Anonym0u3

examples/community/pipeline_stable_diffusion_xl_attentive_eraser.py

    
              logger = logging.get_logger(__name__)  # pylint: disable=invalid-name

              EXAMPLE_DOC_STRING = """

Contributor

hlky Jan 24, 2025

Can we change this to the example from the docs?

examples/community/pipeline_stable_diffusion_xl_attentive_eraser.py Outdated

Comment on lines 177 to 179

    
                      print("AAS at denoising steps: ", self.step_idx)

                      print("AAS at U-Net layers: ", self.layer_idx)

                      print("start AAS")

Contributor

hlky Jan 24, 2025

Suggested change

      
                    print("AAS at denoising steps: ", self.step_idx)
          
                    print("AAS at U-Net layers: ", self.layer_idx)
          
                    print("start AAS")

examples/community/pipeline_stable_diffusion_xl_attentive_eraser.py Outdated

    
                      """

                      if is_cross or self.cur_step not in self.step_idx or self.cur_att_layer // 2 not in self.layer_idx:

                          return super().forward(q, k, v, sim, attn, is_cross, place_in_unet, num_heads, **kwargs)

                      # B = q.shape[0] // num_heads // 2

Contributor

hlky Jan 24, 2025

Suggested change

# B = q.shape[0] // num_heads // 2

examples/community/pipeline_stable_diffusion_xl_attentive_eraser.py Outdated

    
                          return super().forward(q, k, v, sim, attn, is_cross, place_in_unet, num_heads, **kwargs)

                      # B = q.shape[0] // num_heads // 2

                      H = int(np.sqrt(q.shape[1]))

                      # H = W = int(np.sqrt(q.shape[1]))

Contributor

hlky Jan 24, 2025

Suggested change

# H = W = int(np.sqrt(q.shape[1]))

examples/community/pipeline_stable_diffusion_xl_attentive_eraser.py Outdated

Comment on lines 320 to 326

    
                  # checkpoint. TOD(Yiyi) - need to clean this up later

                  deprecation_message = "The prepare_mask_and_masked_image method is deprecated and will be removed in a future version. Please use VaeImageProcessor.preprocess instead"

                  deprecate(

                      "prepare_mask_and_masked_image",

                      "0.30.0",

                      deprecation_message,

                  )

Contributor

hlky Jan 24, 2025

Suggested change

      
                # checkpoint. TOD(Yiyi) - need to clean this up later
          
                deprecation_message = "The prepare_mask_and_masked_image method is deprecated and will be removed in a future version. Please use VaeImageProcessor.preprocess instead"
          
                deprecate(
          
                    "prepare_mask_and_masked_image",
          
                    "0.30.0",
          
                    deprecation_message,
          
                )

This function is still used in other community examples so it's ok to remove the deprecation message here. Alternatively refactor to use VaeImageProcessor.preprocess.


          update_review

e5fc2e4

Co-authored-by: Other Contributor <a457435687@126.com>

Contributor Author

Anonym0u3 commented Jan 24, 2025

Hi, @hlky, I sincerely apologize for the delay caused by my oversight last week in not submitting the review request on time. As a beginner, I truly appreciate your patience and understanding throughout this process.

I’ve carefully reviewed your feedback and have addressed all the suggested changes in a new commit. Please let me know if there’s anything else I need to do before this PR can be merged into the main codebase.

Once again, thank you so much for your valuable feedback and guidance!

Anonym0u3 requested a review from hlky

January 24, 2025 13:11

Contributor

hlky commented Jan 24, 2025

Should be good to go after CI passes. Can you run make style again?


          update_review_ms

bb52aeb

Co-authored-by: Other Contributor <a457435687@126.com>

Contributor Author

Anonym0u3 commented Jan 24, 2025

Thanks. I checked the code and ran the make style again.

hlky approved these changes

View reviewed changes

Contributor

hlky left a comment

Thanks @Anonym0u3

hlky merged commit 87252d8 into huggingface:main

9 checks passed

Anonym0u3 deleted the add-AttentiveEraser branch

February 7, 2025 04:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet