-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[misc] feat: introduce a style bot. #10274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bf57be5
95406d2
35c1552
b967a17
f7c715c
da671ea
91aa46b
a7b04ff
fea8f84
118cb2a
a19230a
d7c24d3
4c7fdea
f778226
ee5cbdd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
name: PR Style Bot | ||
|
||
on: | ||
issue_comment: | ||
types: [created] | ||
|
||
permissions: | ||
contents: write | ||
pull-requests: write | ||
|
||
jobs: | ||
run-style-bot: | ||
if: > | ||
contains(github.event.comment.body, '@bot /style') && | ||
github.event.issue.pull_request != null | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Extract PR details | ||
id: pr_info | ||
uses: actions/github-script@v6 | ||
with: | ||
script: | | ||
const prNumber = context.payload.issue.number; | ||
const { data: pr } = await github.rest.pulls.get({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
pull_number: prNumber | ||
}); | ||
|
||
// We capture both the branch ref and the "full_name" of the head repo | ||
// so that we can check out the correct repository & branch (including forks). | ||
core.setOutput("prNumber", prNumber); | ||
core.setOutput("headRef", pr.head.ref); | ||
core.setOutput("headRepoFullName", pr.head.repo.full_name); | ||
|
||
- name: Check out PR branch | ||
uses: actions/checkout@v3 | ||
env: | ||
HEADREPOFULLNAME: ${{ steps.pr_info.outputs.headRepoFullName }} | ||
HEADREF: ${{ steps.pr_info.outputs.headRef }} | ||
with: | ||
# Instead of checking out the base repo, use the contributor's repo name | ||
repository: ${{ env.HEADREPOFULLNAME }} | ||
ref: ${{ env.HEADREF }} | ||
# You may need fetch-depth: 0 for being able to push | ||
fetch-depth: 0 | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Debug | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you do the same here ? create 3 env variable and use them on the run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do the latest changes work? |
||
env: | ||
HEADREPOFULLNAME: ${{ steps.pr_info.outputs.headRepoFullName }} | ||
HEADREF: ${{ steps.pr_info.outputs.headRef }} | ||
PRNUMBER: ${{ steps.pr_info.outputs.prNumber }} | ||
run: | | ||
echo "PR number: ${{ env.PRNUMBER }}" | ||
echo "Head Ref: ${{ env.HEADREF }}" | ||
echo "Head Repo Full Name: ${{ env.HEADREPOFULLNAME }}" | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v4 | ||
|
||
- name: Install dependencies | ||
run: | | ||
pip install .[quality] | ||
|
||
- name: Download Makefile from main branch | ||
run: | | ||
curl -o main_Makefile https://raw.githubusercontent.com/huggingface/diffusers/main/Makefile | ||
|
||
- name: Compare Makefiles | ||
run: | | ||
if ! diff -q main_Makefile Makefile; then | ||
echo "Error: The Makefile has changed. Please ensure it matches the main branch." | ||
exit 1 | ||
fi | ||
echo "No changes in Makefile. Proceeding..." | ||
rm -rf main_Makefile | ||
Comment on lines
+67
to
+78
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @glegendre01 added this too. LMK if it works for you. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM |
||
|
||
- name: Run make style and make quality | ||
run: | | ||
make style && make quality | ||
|
||
- name: Commit and push changes | ||
id: commit_and_push | ||
env: | ||
HEADREPOFULLNAME: ${{ steps.pr_info.outputs.headRepoFullName }} | ||
HEADREF: ${{ steps.pr_info.outputs.headRef }} | ||
PRNUMBER: ${{ steps.pr_info.outputs.prNumber }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
echo "HEADREPOFULLNAME: ${{ env.HEADREPOFULLNAME }}, HEADREF: ${{ env.HEADREF }}" | ||
# Configure git with the Actions bot user | ||
git config user.name "github-actions[bot]" | ||
git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
||
# Make sure your 'origin' remote is set to the contributor's fork | ||
git remote set-url origin "https://x-access-token:${GITHUB_TOKEN}@github.com/${{ env.HEADREPOFULLNAME }}.git" | ||
|
||
# If there are changes after running style/quality, commit them | ||
if [ -n "$(git status --porcelain)" ]; then | ||
git add . | ||
git commit -m "Apply style fixes" | ||
# Push to the original contributor's forked branch | ||
git push origin HEAD:${{ env.HEADREF }} | ||
echo "changes_pushed=true" >> $GITHUB_OUTPUT | ||
else | ||
echo "No changes to commit." | ||
echo "changes_pushed=false" >> $GITHUB_OUTPUT | ||
fi | ||
|
||
- name: Comment on PR with workflow run link | ||
if: steps.commit_and_push.outputs.changes_pushed == 'true' | ||
uses: actions/github-script@v6 | ||
with: | ||
script: | | ||
const prNumber = parseInt(process.env.prNumber, 10); | ||
const runUrl = `${process.env.GITHUB_SERVER_URL}/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}` | ||
|
||
await github.rest.issues.createComment({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
issue_number: prNumber, | ||
body: `Style fixes have been applied. [View the workflow run here](${runUrl}).` | ||
}); | ||
env: | ||
prNumber: ${{ steps.pr_info.outputs.prNumber }} |
Uh oh!
There was an error while loading. Please reload this page.