Closed
Description
Following the Philosophy, it has been decided to keep different pipelines for Stable Diffusion for txt-to-img, img-to-img and inpainting.
Here is the result:
- PR Add an argument "negative_prompt" #549 : code duplicated 4 times (onnx included)
- PR stable diffusion using < 2.3GB of GPU memory #537 : modification only applied to txt-to-img pipeline
- PR Add callback parameters for Stable Diffusion pipelines #521 : code duplicated 4 times (onnx included)
- PR Removing
autocast
for35-25% speedup
. (autocast
considered harmful). #511 : modification only applied to txt-to-img pipeline - PR Add better compatibility with
diffusers-interpret
(and possibly other use cases!) #506 : modification only applied to txt-to-img pipeline - PR Warning for too long prompts in DiffusionPipelines (Resolve #447) #472 : code duplicated 4 times (onnx included)
- PR Optimize Stable Diffusion #371 : modification only applied to txt-to-img pipeline
It's getting even worse! Now with onnx and the obvious request to have img-to-img and inpainting pipelines with onnx (#510), that would mean that every modification will need to be duplicated 6 times in total, with 6 times the number of tests.
This in untenable...