Fix resolve_pattern for local symlinked files#7973
Open
KOKOSde wants to merge 1 commit intohuggingface:mainfrom
Open
Fix resolve_pattern for local symlinked files#7973KOKOSde wants to merge 1 commit intohuggingface:mainfrom
KOKOSde wants to merge 1 commit intohuggingface:mainfrom
Conversation
KOKOSde
force-pushed
the
fix/symlink-glob-local-files
branch
from
62505f8 to
c70d132
Compare
Some fsspec versions report local symlinks as type='other' and may omit the 'islink' flag. This caused symlinked parquet files (common in HF cache layouts with blob storage) to be excluded from pattern matching. Changes: - Explicitly check os.path.islink() for local file protocol - Add regression test that forces the type='other' scenario Fixes huggingface#7084
KOKOSde
force-pushed
the
fix/symlink-glob-local-files
branch
from
c70d132 to
fefb65d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
resolve_patternfor local symlinked files.Problem: on the local
file://filesystem,fsspeccan report symlinks astype=="other"and omit theislinkflag, so symlinked files are skipped.Fix: when
protocol=="file", treatos.path.islink(filepath)as a link candidate and include it if it resolves to a regular file.Includes a regression test in
tests/test_data_files.py.