Use Sequence instead of list in Dataset.from_parquet type hints#7962
Open
Mukundtimbadiya20 wants to merge 3 commits intohuggingface:mainfrom
Open
Use Sequence instead of list in Dataset.from_parquet type hints#7962Mukundtimbadiya20 wants to merge 3 commits intohuggingface:mainfrom
Mukundtimbadiya20 wants to merge 3 commits intohuggingface:mainfrom
Conversation
Updated type annotations to avoid mypy invariant List issues.
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix mypy invariant type issues by updating type annotations in Dataset.from_parquet from list to Sequence, as discussed in issue #5354. However, the implementation contains critical errors that break backward compatibility.
Changes:
- Added import for
Sequencefromtypingmodule - Changed
path_or_pathsparameter type annotation fromUnion[PathLike, list[PathLike]]toSequence[Union[PathLike, Sequence[PathLike]]] - Changed
columnsparameter type annotation fromOptional[list[str]]toOptional[Sequence[str]]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use collections.abc.Sequence and restore Union[PathLike, Sequence[PathLike]] signature.
Author
|
Thank you for the review! I’ve updated the implementation to:
The fixes are pushed. Please let me know if anything else is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates type annotations in Dataset.from_parquet to use Sequence instead of list to avoid mypy invariant type issues, as discussed in issue #5354.