-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist IterableDataset epoch in workers #6710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
commented
Jul 1, 2024
Show benchmarksPyArrow==8.0.0 Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
|
albertvillanova
pushed a commit
that referenced
this pull request
Aug 13, 2024
* persist IterableDataset epoch in workers * more tests * comment * re-share memory after pickling * Update src/datasets/iterable_dataset.py
albertvillanova
pushed a commit
that referenced
this pull request
Aug 14, 2024
* persist IterableDataset epoch in workers * more tests * comment * re-share memory after pickling * Update src/datasets/iterable_dataset.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shared memory for the IterableDataset epoch.
This way calling
ds.set_epoch()
in the main process will update the epoch in the DataLoader workers as well.This is useful especially because the epoch is used to compute the
effective_seed
used for shuffling.I used torch's shared memory in case users want to send dataset copies without shared memory using pickle. I also find it easier to use than using
multiprocessing.shared_memory
than requires unlinking only in the main process, ormp.Value
that is not picklable.close #6673
cc @rwightman