Support for downloading only provided split #5668
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Thank you.
As discussed in our weekly meeting:
- I already started to work on this long ago: you can see the corresponding PR for context:
- The caching issue should be addressed first:
- Currently, the cache only checks for the existence of the corresponding dataset directory
- It should be enhanced and check the content of that directory, because it might be partially filled with only some of the splits
|
My previous comment didn't create the retro-link in the PR. I write it here again. You can check the context and the discussions we had about this feature enhancement in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pass split to
_split_generators().But I'm not sure if it's possible to solve cache issues, mostly with
dataset_info.json