Skip to content

Unescaped config names with special characters in the URL #2992

Open
@marcenacp

Description

When playing with mlcroissant, we observed the following issue:

bigcode/commitpackft has both the configs c and c#. When going to https://huggingface.co/api/datasets/bigcode/commitpackft/parquet/c#/train/0.parquet, it lists https://huggingface.co/api/datasets/bigcode/commitpackft/parquet/c/train/0.parquet (instead of https://huggingface.co/api/datasets/bigcode/commitpackft/parquet/c%23/train/0.parquet).

Should dataset names / config names be escaped in the URLs?

cc @severo @lhoestq

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Not as needed as P0, but still important/wantedbugSomething isn't workingname issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions