Completed the translation of the first part of Chapter 7 into Russian. #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
MKhalusova
reviewed
Jan 10, 2024
Contributor
MKhalusova
left a comment
MKhalusova
left a comment
There was a problem hiding this comment.
Great work! Left a few nits.
Extra space. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Extra space. I didn't notice. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Extra space. I didn't notice. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Yes, indeed, I ate the space bar))))) Co-authored-by: Maria Khalusova <kafooster@gmail.com>
There's that extra space again. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
There's that extra space again that I didn't notice. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Extra space. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Translated the missing comment.
Extra space. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Translated the missing comment in the code
Translated the missing sentence.
Translated the missing sentence.
I agree, it sounds more neutral that way.
An unnecessary parenthesis. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Also an option, but we've translated it as "карточка модели" a lot of places. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Extra space. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Translated the missing comment in the code.
Extra sapce. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Extra space. Co-authored-by: Maria Khalusova <kafooster@gmail.com>
Translated the missing comment in the code.
Added and translated the missing sentence: "Since the collator expects a list of dicts, where each dict represents a single example in the dataset, we also need to wrangle the data into the expected format before passing it to the data collator:"
Edit the display of the table on the course page.
artyomboyko
commented
Jan 11, 2024
Contributor
Author
artyomboyko
left a comment
artyomboyko
left a comment
There was a problem hiding this comment.
@MKhalusova All done. You can check)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75
This is the first part of the translation of chapter 7 of the course. Since this chapter is very massive, it was decided to split the translation into two parts.
@MKhalusova I'm waiting for your review Maria)