New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve `candle_core::Error` to make it more ergonomic #2467

Open

EricLBuehler wants to merge 4 commits into huggingface:main from EricLBuehler:error_type_improvements

+105 −3

Member

EricLBuehler commented Sep 10, 2024

Currently, our Error type is already useful but could benefit from some of the QoL features which the anyhow crate has.

This PR adds the following:

Make Error::msg more in line with anyhow::Error::msg. Although the type bound changes, this is not a breaking change because std::error::Error: Display already.
Add the Context trait. Inspired by anyhow's Context trait which allows for .with_context and .context on Options and Results. Very useful!

EricLBuehler added 4 commits

September 10, 2024 19:29


          Make Error::msg more in line with anyhow::Error::msg

faffe0d


          Add context trait

d8fa3e1


          Even more flexible

acd1afd


          Format

bbd7127

EricLBuehler mentioned this pull request

Use nicer Candle Error APIs EricLBuehler/mistral.rs#767

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet