Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComfyUI to Gradio/Spaces blog #2553

Merged
merged 17 commits into from
Jan 14, 2025
Merged

ComfyUI to Gradio/Spaces blog #2553

merged 17 commits into from
Jan 14, 2025

Conversation

apolinario
Copy link
Contributor

Preparing the Article

  • Add an entry to _blog.yml.
  • Add a thumbnail. There are no requirements here, but there is a template if it's helpful.
  • Check you use a short title and blog path.
  • Upload any additional assets (such as images) to the Documentation Images repo. This is to reduce bloat in the GitHub base repo when cloning and pulling. Try to have small images to avoid a slow or expensive user experience.
  • Add metadata (such as authors) to your md file. You can also specify guest or org for the authors.
  • Ensure the publication date is correct.
  • Preview the content. A quick way is to paste the markdown content in https://huggingface.co/new-blog. Do not click publish, this is just a way to do an early check.

Getting a Review

A review would be nice: @cbensimon, @pcuenca and @linoytsaban; @cbensimon , I'm unsure about the last part wrt to moving the models outside of the function, do you think there is a more elegant way to convey this? Maybe just the link to the diff without hardcoding it?

@apolinario apolinario changed the title Comfyui to spaces ComfyUI to Gradio/Spaces blog Dec 19, 2024
@apolinario
Copy link
Contributor Author

Also cc @abidlabs, @asomoza and @Vaibhavs10 for viz

Copy link

@cbensimon cbensimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me regarding ZeroGPU

@cbensimon
Copy link

cbensimon commented Dec 20, 2024

@cbensimon , I'm unsure about the last part wrt to moving the models outside of the function, do you think there is a more elegant way to convey this? Maybe just the link to the diff without hardcoding it?

One solution is to take a much simpler (meaning only one or two loading model Nodes) exported workflow as example (either for the whole blog, or only for this part)

_blog.yml Outdated Show resolved Hide resolved
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tutorial @apolinario! Its a bit of work, but nice to see there's a repeatable path that users can follow

Copy link
Contributor

@linoytsaban linoytsaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool! 🎉

run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
run-comfyui-workflows-on-spaces.md Outdated Show resolved Hide resolved
apolinario and others added 6 commits January 8, 2025 08:06
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: Linoy Tsaban <57615435+linoytsaban@users.noreply.github.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: Linoy Tsaban <57615435+linoytsaban@users.noreply.github.com>
Co-authored-by: Linoy Tsaban <57615435+linoytsaban@users.noreply.github.com>
apolinario and others added 4 commits January 8, 2025 08:09
Co-authored-by: Linoy Tsaban <57615435+linoytsaban@users.noreply.github.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@apolinario apolinario merged commit dd9d2af into main Jan 14, 2025
1 check passed
@apolinario apolinario deleted the comfyui-to-spaces branch January 14, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants