Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skip_first_batches support for StatefulDataloader and fix all the tests #3068

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Sep 2, 2024

What does this PR do?

Fixes our variety of failing tests on main.

Namely:

  • removes StatefulDataloader from skip_batch_sampler stuff. There is no need since the dataloader can resume itself, so we don't want users to do so by accident imo.
  • Tweaks the pippy tests to deal with the changes, and adds one for bert (at this time, we can't support vision models, and they dropped support for encoder/decoder)
  • RIP SD v1-5

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@muellerzr muellerzr requested a review from SunMarc September 2, 2024 15:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr changed the title Fix all the tests Remove skip_first_batches support for StatefulDataloader and fix all the tests Sep 2, 2024
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests ! LGTM ! Just a nit

src/accelerate/data_loader.py Show resolved Hide resolved
@muellerzr muellerzr merged commit 8931e5e into main Sep 2, 2024
15 checks passed
@muellerzr muellerzr deleted the muellerzr-fix-tests branch September 2, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants