4-bit quantization meta device bias loading bug: fixes #2742 #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thanks for fixing this @MuhammedHasan ! If you could add a test, that would be perfect. LGTM ! Make sure to run make style to fix the CI.
| if ( | ||
| not getattr(module.weight, "quant_state", None) | ||
| and device_index is not None | ||
| and str(module.weight.device) != "meta" |
There was a problem hiding this comment.
Let's put this additional condition in the above condtion where we check for Linear4bit class , to mimic what we did for Linear8bitLt
|
I'm finishing this PR since no changes were made from the past 3 weeks. @MuhammedHasan, you will be included as a co-author of the PR since I used the commit here. |
|
Closing this PR since the issue has been fixed in the PR above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2742
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.