This repository was archived by the owner on Jan 21, 2026. It is now read-only.
[pull] memtable_as_log_index from topling:memtable_as_log_index#2
Merged
imbajin merged 175 commits intohugegraph:memtable_as_log_indexfrom Jan 12, 2026
Merged
Conversation
rockeet
force-pushed
the
memtable_as_log_index
branch
from
8f386fc to
d34aeaf
Compare
rockeet
force-pushed
the
memtable_as_log_index
branch
5 times, most recently
from
98475e4 to
73e3caa
Compare
rockeet
force-pushed
the
memtable_as_log_index
branch
from
73e3caa to
92f97ae
Compare
and squashed commits:
- merging_iterator.cc: extract macro MERGE_ITER_CMP_PREFIX(cmp)
- merging_iterator.cc: change sizeof(HeapItemAndPrefixFast.prefix_cache) to 24 on avx512
Because iter_type is useless for HeapItemAndPrefixFast, prefix_cache can be 24,
and 24 fit 6 uint32 fields, in MyTopling, it fits 5 user fields(except 1 uint32
prefix for table/index id)
- merging_iterator.cc: UpdatePrefixCache() bug fix: use user_key & load/store mask is different
This makes the code simple and NOT repeat
rockeet
force-pushed
the
memtable_as_log_index
branch
from
55e8f40 to
3e4c9d5
Compare
blsi(x) = x & -x, while lt is a subset of neq, so (lt & neq) == lt, so lt & (neq & -neq) == (lt & neq) & -neq == lt & -neq
VirtualCmpNoTS is not our optimization target, just let it works, this is still faster than upstream rocksdb by static bound condtion `prefix_same_as_start_` and `iterate_upper_bound_`.
rockeet
force-pushed
the
memtable_as_log_index
branch
from
67ede94 to
5241049
Compare
Also add Slice::notail(n)
When it is 128, minimal_sso.local_size() is faster because 128 is power of 2 thus can be optimized to (127 xor m_unused_len).
PrepareAndGetValue::PrepareAndGetValue() also use work_iter_
rockeet
force-pushed
the
memtable_as_log_index
branch
from
a7c5c2e to
03aeb5a
Compare
If Next() reach a file_iter boundary, then call Prev(), reset scan func is needed, for example: ```c++ iter->Seek(); assert(iter->Valid()); iter->Next(); assert(iter->Valid()); iter->Next(); assert(iter->Valid()); // switch to next file iter->Prev(); assert(iter->Valid()); // switch to prev file iter->Next(); assert(iter->Valid()); // switch to next file ```
This is mainly for MergingIterator and works well for others.
compiler optimzation can fold top_changed branch with update_top() after inline expansion.
…etch Set value fetch functions to reduce calling chains, just optimize forward scan, keep backward scan safe and correct.
DBIter is embeded in ArenaWrappedDBIter -- although the overhead is very small, this commit provide a way to remove it.
rockeet
force-pushed
the
memtable_as_log_index
branch
from
bb00de1 to
4bac285
Compare
And use iter->GetUnwrapped() for readseq -- same as nextwithkey
rockeet
force-pushed
the
memtable_as_log_index
branch
from
bf22eca to
06049f0
Compare
…1) as fail When `iter->value().size() == size_t(-1)`, user code should consider `iter->status()` for detailed error!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )