Skip to content

Verify value is defined before trying to run a min/max length value. #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2016
Merged

Verify value is defined before trying to run a min/max length value. #240

merged 1 commit into from
Oct 14, 2016

Conversation

liorcode
Copy link
Contributor

this will help avoid a TypeError when no value is entered and min length/max length validators are used.

@coveralls
Copy link

coveralls commented Sep 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 93.617% when pulling 9f964df on liorch88:validate-min-max-value into 531cb12 on huei90:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling 9f964df on liorch88:validate-min-max-value into 531cb12 on huei90:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling 9f964df on liorch88:validate-min-max-value into 531cb12 on huei90:master.

@liorcode liorcode mentioned this pull request Sep 26, 2016
Closed
@hueitan
Copy link
Owner

hueitan commented Oct 14, 2016

Sorry for the late review,

Thanks for fixing the issue. 🍻

@hueitan hueitan merged commit 525ca99 into hueitan:master Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liorcode @coveralls @hueitan