-
-
Notifications
You must be signed in to change notification settings - Fork 2
Project-specific config #11
Conversation
|
@hudochenkov, any comments? |
|
Sorry, I'm in a middle of relocation process and don't have time to review. Will review in a two weeks or so. |
|
Thank you for your patience! Looks pretty good! Anything else you want to add to your PR? |
|
No, I think it covers the problem. But now we are having problems with versions. See, this plugin still depends on postcss-sorting 2, when vscode and atom plugins moved on to version 3. And they have some changes in config file structure: https://github.com/hudochenkov/postcss-sorting#migration-from-2x What do you think about it? Do you have plans to upgrade dependencies? If not, I can try and work on it. |
|
Sure, it should've been updated to v3 a long time ago. I'll update it soon. Thank you for your support! |
|
Thank you for plugin :) |
|
@stfoo |
|
Nice! Thanks |
Hello!
I am new to sublime packages, python and public pull request. So please correct me if I did something wrong.
Problem
I am using
postcss-sortingandsublime-postcss-sortingto keep my styles in nice shape. Recently my team started to use this tools too. But we have an annoying problem with sharing our configs.For now, there are two ways to configure this plugin: you can use global configuration and
.sublime-project. First one is obviously doesn't fit for us. The problem with second is that not everybody in our team using Sublime.Solution
Use editor-agnostic configuration file. Both atom-postcss-sorting and vscode-postcss-sorting make use of
.postcss-sorting.jsonandpostcss-sorting.jsonfiles andpostcssSortingConfigsection ofpackage.json. So I thought it woud be a good idea to teach sublime-postcss-sorting do the same.Implementation
I am new to this, so before implementing all of the features I tried to make a basic lookup for
.postcss-sorting.jsonand parse it. Am I heading in the right direction? :)