Skip to content
This repository was archived by the owner on May 31, 2021. It is now read-only.

Conversation

@rusty-key
Copy link

Hello!

I am new to sublime packages, python and public pull request. So please correct me if I did something wrong.

Problem

I am using postcss-sorting and sublime-postcss-sorting to keep my styles in nice shape. Recently my team started to use this tools too. But we have an annoying problem with sharing our configs.

For now, there are two ways to configure this plugin: you can use global configuration and .sublime-project. First one is obviously doesn't fit for us. The problem with second is that not everybody in our team using Sublime.

Solution

Use editor-agnostic configuration file. Both atom-postcss-sorting and vscode-postcss-sorting make use of .postcss-sorting.json and postcss-sorting.json files and postcssSortingConfig section of package.json. So I thought it woud be a good idea to teach sublime-postcss-sorting do the same.

Implementation

I am new to this, so before implementing all of the features I tried to make a basic lookup for .postcss-sorting.json and parse it. Am I heading in the right direction? :)

@rusty-key
Copy link
Author

@hudochenkov, any comments?

@hudochenkov
Copy link
Owner

Sorry, I'm in a middle of relocation process and don't have time to review. Will review in a two weeks or so.

@hudochenkov
Copy link
Owner

Thank you for your patience! Looks pretty good!

Anything else you want to add to your PR?

@rusty-key
Copy link
Author

No, I think it covers the problem.

But now we are having problems with versions. See, this plugin still depends on postcss-sorting 2, when vscode and atom plugins moved on to version 3. And they have some changes in config file structure: https://github.com/hudochenkov/postcss-sorting#migration-from-2x

What do you think about it? Do you have plans to upgrade dependencies? If not, I can try and work on it.

@hudochenkov
Copy link
Owner

Sure, it should've been updated to v3 a long time ago. I'll update it soon.

Thank you for your support!

@hudochenkov hudochenkov merged commit 5c03834 into hudochenkov:master Dec 27, 2017
@rusty-key rusty-key deleted the project-config branch December 27, 2017 12:34
@rusty-key
Copy link
Author

Thank you for plugin :)

@hudochenkov
Copy link
Owner

@stfoo 3.0.0 released. With your feature and postcss-sorting@3.1.0.

@rusty-key
Copy link
Author

Nice! Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants