Add space between subclasses, children styles

[scalder27]

It would be cool keep indentation between ">child" classes. Much more readable.
Also, I`ve had in mind a csscomb.js issue about this (csscomb/csscomb.js#441).

[hudochenkov]

Thank you for your PR, but I can't accept it yet. This is breaking change. It will break backward compatibility. And I personally don't like this empty lines, but it may be useful for some developers.

You may add a new option empty-lines-between-children-rules to config for adding empty lines between children. The config will look like this:

{
    "sort-order": [
        [
            "display",
            "visibility",
            "..."
        ],
        [ ">child" ]
    ],
    "empty-lines-between-children-rules": 1
}

This will add 1 empty line between child rules. The default value should be set to 0, so nothing breaks for users when they update to the new plugin version.

P. S. CSSComb's issue you mention is already solved by this plugin :)

[scalder27]

Thank you for responding so quickly! Your arguments sound resonable, I`ll add option.
P.S. Indeed! My bad =(

[scalder27]

@hudochenkov, is it better now?

[hudochenkov]

Should be return run(t, 'lines-between-children.expected', {, because second argument for run() is file name without extension. Also rename .scss to .css. You will see if tests working if file lines-between-children.actual.css will be created after tests run. This file will show what is actual output of the current test.

[scalder27]

facepalm on my face! Copy paste is evil!
Fixed it

[hudochenkov]

@scalder27 this is very cool! Please fix issues I'm commented about. Can you also add documentation for new option?

[scalder27]

@hudochenkov issues was fixed, documentation was added =)
Thanks for the cool review! It was good!

[hudochenkov]

@scalder27 this is amazing! Can you make the last two changes, please? :)

• Add space after if: if( → if (.
• Squash all commits to one.

[scalder27]

@hudochenkov amazingly Ive managed to do the last two changes =) And, please, pay attention: Ive added eslint rule and --fix param to npm lint script, is it ok? I just wasn`t in a fixing if-stuffs manually mood...

[hudochenkov]

You did a great work, @scalder27! Thank you!

[scalder27]

Thank you, @hudochenkov, you did a really great work with postcss-sorting! When csscomb.js let us down, your project saved us from an unavoidable stylesheets entropy =)
It was a pleasure work with you!

[hudochenkov]

@scalder27 I've released the new version :)

[scalder27]

@hudochenkov, its unbelievably awesome! My first github contribution! To the instrument that I and my team using daily. Coool!