Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SD15 Support #44

Merged
merged 12 commits into from
Mar 9, 2024
Merged

Implement SD15 Support #44

merged 12 commits into from
Mar 9, 2024

Conversation

huchenlei
Copy link
Owner

@huchenlei huchenlei commented Mar 9, 2024

Closes #42.

LayerDiffuse SD15 brings 4 new models:

Generate FG

Use the apply node the same way as before.
sd15_fg

Generate FG + Blended given BG

Need batch size = 2N.
sd15_cond_joint_bg

Generate BG + Blended given FG

Need batch size = 2N.
sd15_cond_joint_fg

Generate BG + FG + Blended together

Need batch size = 3N.
sd15_joint

Notes:

  • Dropdown options in previous nodes are updated. You will need to re-select the config for your previous workflows
  • Unlike forge impl, which does cond concat for fg/bg/blended, in ComfyUI impl, the cond passed to layer diffusion node directly overwrites the global cond.
  • LayerDiffuseDecode (Split) is added to decode RGBA every N images. It serves the purpose to only decode FG images in a batch.

@huchenlei huchenlei marked this pull request as ready for review March 9, 2024 07:01
@DrakenZA
Copy link

DrakenZA commented Mar 9, 2024

Very nice. Is the upgrade on diffusers a requirement ? (i disabled your check on my local copy, cause often changing diffusers can kill other custom nodes that havnt prepared their code for the newer diffusers etc)

edit: It does seem like it needs that version of diffusers. Hmm, hopefully other nodes i use are up to date haha :).

Thanks again for your work

@kacecarol
Copy link

can't wait to try, and got this:

Error occurred when executing KSampler:

CUDA error: invalid configuration argument
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.

exactly the same workflow as yours.

@huchenlei huchenlei merged commit dc48c4b into main Mar 9, 2024
2 checks passed
@huchenlei huchenlei deleted the sd15 branch March 9, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: SD1.5 Support (Models Have Released)
3 participants