Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade contentful eslint #566

Merged
merged 3 commits into from
Feb 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 103 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 10 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,25 @@
{
"private": true,
"devDependencies": {
"@types/node": "^13.7.0",
"@typescript-eslint/eslint-plugin": "^2.19.2",
"@typescript-eslint/parser": "^2.19.2",
"@types/jest": "^25.1.3",
"@types/jest-each": "^24.3.0",
"@types/node": "^13.7.2",
"@typescript-eslint/eslint-plugin": "^2.20.0",
"@typescript-eslint/parser": "^2.20.0",
"babel-eslint": "^10.0.3",
"eslint": "^6.8.0",
"eslint-plugin-filenames": "^1.3.2",
"eslint-config-prettier": "^6.10.0",
"eslint-plugin-filenames": "^1.3.2",
"eslint-plugin-jest": "^23.7.0",
"eslint-plugin-no-null": "^1.0.2",
"eslint-plugin-prettier": "^3.1.2",
"eslint-plugin-react": "^7.18.3",
"eslint_d": "^8.0.0",
"eslint_d": "^8.1.0",
"jest": "^25.1.0",
"lerna": "^3.19.0",
"prettier": "^1.19.1",
"ts-jest": "^25.2.1",
"ts-mockito": "^2.5.0",
"ts-node": "^8.6.2",
"tslib": "^1.10.0",
"typescript": "~3.7.5"
Expand Down
12 changes: 7 additions & 5 deletions packages/botonic-cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ $ npm install -g @botonic/cli
$ botonic COMMAND
running command...
$ botonic (-v|--version|version)
@botonic/cli/0.10.1 darwin-x64 node-v10.15.0
@botonic/cli/0.10.1 linux-x64 node-v13.9.0
$ botonic --help [COMMAND]
USAGE
$ botonic COMMAND
Expand All @@ -46,9 +46,11 @@ USAGE
$ botonic deploy [BOT_NAME]

OPTIONS
-c, --command=command Command to execute from the package "scripts" object
-f, --force Force deploy despite of no changes. Disabled by default
--botName=botName
-b, --botName=botName Name of the bot from Hubtype where you want to deploy
-c, --command=command Command to execute from the package "scripts" object
-e, --email=email Email from Hubtype Organization
-f, --force Force deploy despite of no changes. Disabled by default
-p, --password=password Password from Hubtype Organization

EXAMPLE
$ botonic deploy
Expand Down Expand Up @@ -180,7 +182,7 @@ OPTIONS

EXAMPLE
$ botonic train
TRAINING MODEL FOR {LANGUAGE}...
TRAINING MODEL FOR {LANGUAGE}...
```

_See code: [src/commands/train.ts](https://github.com/hubtype/botonic/blob/v0.10.1/src/commands/train.ts)_
Expand Down
15 changes: 5 additions & 10 deletions packages/botonic-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,22 @@
"bugs": "https://github.com/hubtype/botonic/issues",
"dependencies": {
"@oclif/command": "^1.5.19",
"@oclif/config": "^1.13.3",
"@oclif/config": "^1.14.0",
"@oclif/plugin-help": "^2.2.3",
"analytics-node": "^3.4.0-beta.1",
"axios": "^0.19.0",
"colors": "^1.2.5",
"axios": "^0.19.2",
"colors": "^1.4.0",
"folder-hash": "^3.3.0",
"form-data": "^3.0.0",
"fs-extra": "^8.1.0",
"inquirer": "^7.0.4",
"ora": "^3.4.0",
"tslib": "^1.10.0",
"tslib": "^1.11.0",
"zip-a-folder": "0.0.12"
},
"devDependencies": {
"@oclif/dev-cli": "^1.22.2",
"@oclif/test": "^1.2.5",
"@types/node": "^13.1.6",
"globby": "^11.0.0",
"ts-node": "^8.5.4"
"globby": "^11.0.0"
},
"engines": {
"node": ">=8.0.0"
Expand Down Expand Up @@ -57,9 +54,7 @@
"prepare": "node ../../preinstall.js",
"build": "rm -rf lib && tsc",
"postpack": "rm -f oclif.manifest.json npm-shrinkwrap.json",
"posttest": "tslint -p test -t stylish",
"prepack": "oclif-dev manifest && oclif-dev readme && npm shrinkwrap",
"test": "nyc --extension .ts mocha --forbid-only \"test/**/*.test.ts\"",
"version": "oclif-dev readme && git add README.md",
"postinstall": "node scripts/postinstall.js",
"lint": "npm run lint_core -- --fix",
Expand Down
5 changes: 1 addition & 4 deletions packages/botonic-plugin-contentful/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ module.exports = {
// special for TYPESCRIPT
"@typescript-eslint/explicit-function-return-type": "off", // annoying for tests
"@typescript-eslint/explicit-member-accessibility": "off", //we think defaulting to public is a good default
"@typescript-eslint/no-empty-function": "warn",
"@typescript-eslint/no-namespace": ["error", { allowDeclarations: true }], // to encapsulate types in namespace with same name as Class
"@typescript-eslint/no-non-null-assertion" : "warn", // specially useful in tests, and "when you know what you're doing"
"@typescript-eslint/no-object-literal-type-assertion" : [ "error", {allowAsParameter: false}], //useful to pass options to plugins
"@typescript-eslint/no-parameter-properties": "off", // opinionated: parameter properties make data classes shorter
// allow public functions/classes to call private functions/classes declared below.
// otoh, variables (typically constants) should be declared at the top
Expand All @@ -63,9 +63,6 @@ module.exports = {
"files": [
"tests/**/*.ts" // to be able to skip required fields when not used in a particular test
],
"rules": {
"@typescript-eslint/no-object-literal-type-assertion" : "off",
}
}
],
env: {
Expand Down
Loading