botonic CI: Improve and simplify CI with biome for all packages#3165
Open
Iru89 wants to merge 3 commits intoreplace-eslint-and-prettier-for-biome-7from
Open
botonic CI: Improve and simplify CI with biome for all packages#3165Iru89 wants to merge 3 commits intoreplace-eslint-and-prettier-for-biome-7from
Iru89 wants to merge 3 commits intoreplace-eslint-and-prettier-for-biome-7from
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Test Results42 tests 42 ✅ 1m 27s ⏱️ Results for commit f09329f. |
Iru89
changed the base branch from
master-lts
to
replace-eslint-and-prettier-for-biome-7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that all packages in the monorepo have been migrated to Biome, this PR updates the CI configuration and removes unused QA scripts that were leftover from the ESLint/Prettier setup.
Changes
CI Workflows
botonic-common-workflow.yml: Changed the defaultLINT_COMMANDfromnpm run lint_core(ESLint) tonpm run lint:check(Biome), since all packages now use Biome.LINT_COMMANDfrom 6 package-specific workflows (botonic-core,botonic-cli,botonic-react,botonic-plugin-ai-agents,botonic-plugin-flow-builder,botonic-plugin-hubtype-analytics). They now rely on the updated default from the common workflow.botonic-ci-test-all-packages.yml(manual workflow), which never specifiedLINT_COMMANDand was falling back to the oldnpm run lint_coredefault.Deleted files
packages/.eslintrc.js— Shared ESLint config no longer used by any package.scripts/qa/lint-package.ts— Unreferenced script that rannpm run lintper package.scripts/qa/lint-all-packages.ts— Unreferenced script that iterated all packages callinglint-package.ts.scripts/qa/lint-d-ts.ts— Unreferenced TypeScript type-checking script (tsc --noEmit).scripts/qa/old/lint-all-packages.sh— Legacy bash version oflint-all-packages.ts.scripts/qa/old/lint-d-ts.sh— Legacy bash version oflint-d-ts.ts.