Skip to content

Removes Flurl dependency #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Removes Flurl dependency #93

merged 1 commit into from
Oct 9, 2020

Conversation

Psypher9
Copy link
Member

@Psypher9 Psypher9 commented Oct 9, 2020

Description

This PR addresses issue #92 and removes the need for Flurl as a dependency.

This is only meant to be an intermediate solution before simplifying the way query strings are generated with ListRequestOptions. See #91 for more information

Purpose

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests to prove that what I have fixed or added does indeed work
  • I have added documentation as necessary

@Psypher9 Psypher9 merged commit 5a4f646 into master Oct 9, 2020
@radek-petrik-se
Copy link

I suggest rollback for this merge/pull request. For removing the Flurl dependency just replace the SetQueryParam extension with own implementation of the same functionality. It will be easier to maintain and also fix errors like missing escaping, missing ampersands, etc. . I have marked just one example of missing ampersand in the commit 5a4f646, but there are many more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants