Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both Dataset.files and Dataset.ingest_metadata.files #705

Closed
shirey opened this issue Jul 19, 2024 · 1 comment
Closed

Support both Dataset.files and Dataset.ingest_metadata.files #705

shirey opened this issue Jul 19, 2024 · 1 comment

Comments

@shirey
Copy link
Member

shirey commented Jul 19, 2024

Only do this after search-api #857 Remove ancetor.* and descendant.* fields has been completed

We would like to stop adding file information under the Dataset.ingest_metadata field. To this end we'll ask all groups who use this file information to start using it directly from Dataset.files. In the interim we need to make sure that

  • if data comes in (PUT or POST) at Dataset.files or Dataset.ingest_metadata.files that a copy of it ends up in both places.
    • In search-api make sure the files object isn't copied to the top level any longer- BUT because we now send it from entity-api in both places, make sure that it is still in the ES indices in both places.
  • make sure any existing Dataset.files or Dataset.ingest_metadata.files is retrofitted (copied) to both places for existing Datasets

NOTE: After this has been completed we will then need to:

  • Ask consumers of files (Harvard, IU, other?) to start using it from Dataset.files
  • Ask PSC to only send files information to Dataset.ingest_metadata.files
  • Remove this patch
  • Remove all Dataset.ingest_metadata.files (Neo4j and ES)
@shirey shirey added this to Pitt HIVE Jul 19, 2024
@shirey shirey converted this from a draft issue Jul 19, 2024
@shirey
Copy link
Member Author

shirey commented Oct 29, 2024

Won't do because this handled in #748

@shirey shirey closed this as completed Oct 29, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Pitt HIVE Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants