Feat/new stdout exporter switches (Add option to display more than five processes) #98
Conversation
| scaphandre stdout -p 20 | ||
|
|
||
| You can filter the processes to display with `-r`. A warning will be risen if this option is used with `-p` at the same time. | ||
| In such case, `-p` behavior is disabled. |
There was a problem hiding this comment.
I'd find more intuitive to pe able to use both. -p could then be used to limit the number of results from -r. Is there a particular challenge to do it I don't see right now ? WDYT ?
There was a problem hiding this comment.
Hello @bpetit,
No there is no challenge to mix the both options. However I made it "incompatible" because, the default value of -p is 5 even if you don't specify it. I thought it could be misleading, because it could truncate the filtered output silently.
There was a problem hiding this comment.
I understand. Actually it seems fine to me too to declare those options incompatible.
- Introduce new switches -p (number of consumers) and -r (regex filter) - Display the chosen number of consumers - Start implementation of filter
- Filters implemented TODO: - Refactor get_filtered_processes(). - Explain that -f as priority over -p. - Documentation update.
- Refactor get_filtered_processes() and get_top_consumers().
- Explain that -r as priority over -p. - Add a warning if -p and -r are used at the same time. - Remove default values for regex_filter.
- Update documentation.
- Fix clippy warnings
uggla
force-pushed
the
feat/new_stdout_exporter_switches
branch
from
35e00fc
to
394b81e
Compare
|
@bpetit , this is rebased.
Despite I checked it, please have a quick new review to be sure the rebase has not introduced something wrong. Then I think you will be able to merge this MR. |
Hello,
This MR fixes #91.