-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/riemann exporter #58
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d24a51d
feat: initial Riemann exporter
uggla 9c64594
fix: clean code
uggla b72e064
fix: improve run function readability
uggla 71ceec8
feat: draft send item to Riemann
uggla 35fa6e7
feat: Add hostname
uggla 00c8087
feat: Add a Metric trait
uggla a03d0f3
feat: Refactor Metric
uggla b7c4980
feat: Allow to pass more characteristics to events
uggla bfd11ab
fix: Missing crate protobuf
uggla d561808
feat: Add new metrics
uggla ed6137c
fix: Typo
uggla bfd1b1f
feat: Add new measures
uggla 58652aa
feat: Refactor
uggla 1ba1f0b
fix: Use Option for parameters default values
uggla be4f6c8
fix: Add option qemu
uggla 85c0893
feat: Introduce processes
uggla ca2b693
feat: Add vmname
uggla 1accdc2
feat: Update documentation
uggla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never tried it but you also have https://github.com/sunng87/rustmann which supports stuff like mTLS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your experience is this a must have or a nice to have for a riemann client ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting because based on tokio as well, but maybe a bit early to use this client. As stated in the presentation.
So we may run to adapt the code to the api changes. I think we can keep an eye on it and move as soon as the api is more stable and if it makes sens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not mandatory but I usually run all of my services using mTLS if I can.
But as @uggla said, the current lib may be enough for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your feedbacks. Let's keep this one for now and keep an eye on rustmann :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option could be to add mTLS to the current riemann client using rustls. Seems not "too hard" although with security it is never as easy as it looks...