Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't create PSP if k8s >= 1.25 #250

Merged
merged 1 commit into from
May 11, 2023

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Jan 3, 2023

@bpetit This is a fix for #246

I opened it against main but LMK if I should be targeting dev 🙏

@Bengrunt
Copy link

Hello,
I believe a similar solution should be applied to the templates/rbac.yaml file for the following part:

- apiGroups:
  - extensions
  resources:
  - podsecuritypolicies
  resourceNames:
  - {{ .Chart.Name }}
  verbs:
  - "use"

In my understanding, if PSPs are not generated then this is not needed.

@bpetit
Copy link
Contributor

bpetit commented Apr 24, 2023

Hi !

It would be great to target dev if you can @rossf7 thanks !

Should @Bengrunt's proposition be added to this PR ? what do you think ?

@rossf7 rossf7 force-pushed the fix/#246-helm-k8s-1-25-psp-fix branch from 0a588be to 043aecf Compare May 4, 2023 18:06
@rossf7 rossf7 changed the base branch from main to dev May 4, 2023 18:07
@rossf7
Copy link
Contributor Author

rossf7 commented May 4, 2023

Hey!

Thank you @Bengrunt you're right the rbac template should be updated too

@bpetit PR is updated and now targets dev

@bpetit bpetit linked an issue May 11, 2023 that may be closed by this pull request
@bpetit bpetit merged commit 933e29b into hubblo-org:dev May 11, 2023
@rossf7 rossf7 deleted the fix/#246-helm-k8s-1-25-psp-fix branch June 8, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Previous releases
Development

Successfully merging this pull request may close these issues.

Not able to install using kubernetes
3 participants