Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add service monitor on helm chart #230

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

mmadoo
Copy link
Contributor

@mmadoo mmadoo commented Oct 26, 2022

Allow configuration of service monitor in order to have metrics collected by an external prometheus

Signed-off-by: Nicolas Trangosi nicolas.trangosi@dcbrain.com

@mmadoo
Copy link
Contributor Author

mmadoo commented Dec 19, 2022

Is it possible to have a feedback on this PR ?
If it is accepted, I could create new pull requests on the helm part of this project.

Allow configuration of service monitor in order to have metrics collected by an external prometheus

Signed-off-by: Nicolas Trangosi <nicolas.trangosi@dcbrain.com>
@bpetit
Copy link
Contributor

bpetit commented Apr 20, 2023

Thanks a lot ! merging !

@bpetit bpetit merged commit b64497b into hubblo-org:dev Apr 20, 2023
@damienvergnaud
Copy link

Oops, i missed this, 1 hour too late,

Having the ability to add labels on this service-monitor object from the values of the chart would help configuration with already existing prometheus stack.

For example the kubernetes-prometheus stack (install Prom + Prom-operator + Grafana headless)
Will automatically grab service-monitor objects with this label :

labels:
  release: prometheus-stack

I'll love to engage with you on further PR @mmadoo you may ping me 👍

@mmadoo
Copy link
Contributor Author

mmadoo commented Apr 20, 2023

I'll love to engage with you on further PR @mmadoo you may ping me 👍
@damienvergnaud I will try to work on this next week. I have other modifcations I would like to add on helm chart, but I was waiting for this PR to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Previous releases
Development

Successfully merging this pull request may close these issues.

3 participants