-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaphandre doesn't work on AMD Zen #55
Comments
HI ! Thanks for reporting. It seems we have to check for different modules if the cpu is from AMD. Investigations to come. |
Same error with "AMD Ryzen 5 2600X Six-Core Processor" (perf also reports data). Here is the full output with the correct option:
|
Hi, Thanks for reporting ! I'll create a PR for that. If you could test it, once its there and before merging, it would be great ! |
It seems possible that a 5.11 kernel could be required: https://www.phoronix.com/scan.php?page=news_item&px=AMD-Zen-PowerCap-RAPL-5.11 I don't see quite clearly the requirement right now for AMD. I'll create a PR that just avoids panicking if the intel modules are not found. This way you could tell me what happens next. (sorry I don't have an AMD box right now, so I place my hopes on you to make that topic go forward :D ) I saw that perf seems to work in 5.8 in your case @barnumbirr . Let's see how it goes with scaphandre with that PR. |
Could you build and try with this version: #65 ? 🙏🏽 Let's see what happens and start from there :) |
Thanks a lot for investigating this :)
|
I'm looking for a hosting or cloud provider to get an AMD zen testing machine, but I'm having a hard time finding an offer at a reasonable price. Do you know some ? Or do you have such a machine available for test on the Internet by any chance ? |
I may have found one thanks to @airclovis ! 👏🏽 https://www.skysilk.com/amd-epyc-servers/ EDIT; after all it seems they provide only VPSs, no bare metal |
You'd probably run into the same issue with Hetzner |
If you are interested in testing on "AMD Ryzen 5 2600X Six-Core Processor", contact me at grego_scaphandre@familleseux.net and I'll provide you an access to a bare-metal machine (not a professional server, it's just a regular PC acting like a server). |
I may give it a try and I'll send you an email, thanks ! However I'm looking for a cloud/hosting offer too in order to integrate tests on amd in PR checks. |
I'll start some tests thanks to @kamaradclimber generous offer (thank you ! 🥳 ) |
…-on-amd-zen fix: allowing scaph to run even if intel_rapl modules r not found
Thanks to @kamaradclimber (🙏🏽 🥳 ) I've been able to validate that with a kernel >5.11, the power consumption data is accessible through the powercap module for AMD, as it is on Intel CPUs (and that scaphandre works correctly in that context). So the simplest way to make scaphandre work on AMD would be to have a kernel >=5.11. That being said, to support more CPUs/kernel combos, I think being able to collect the data directly from the MSR like perf does would be great (I can think of some other usecases where it is necessary). So I think I'll open a new FR to work on an MSR based sensor. So for now, I'm writing that in the documentation right now. We may be able to propose something else for older kernels later (through MSR)... stay tuned (and don't hesitate to jump on the topic if you want to contribute 😀 ) |
Bug description
Trrying to get
scaphandre
running on AMD Zen (Ryzen 5 Pro 2500U) results in thread panic.To Reproduce
msr-tools
scaphandre stdout -t 15
Output:
Expected behavior
scaphandre
should work as AMD RAPL support was added to kernel 5.8 andperf
seems to return sensible data:Environment
Thank you again for creating
scaphandre
and please do let me know if I can help test this further.Cheers.
The text was updated successfully, but these errors were encountered: