Renaming debian builds

[yassingh]

Replacing underscore with dash to make debian build name similar to other os name.

I should have pushed this change in #638
But I caught this discrepancy in build names later.

[basepi]

My brain is trying to tell me there was an issue around underscores vs dashes in Debian. But I can't for the life of me find it -- as far as I can tell we've been using underscores since we first had Debian package support. Maybe I was using underscores for the RPMs and that was the issue? I'm not sure.

Will this affect Debian's willingness to upgrade from an _ to a - version? Have you tested the upgrade path?

[fossam]

Debian didn't like underscores in their version strings (https://www.debian.org/doc/debian-policy/ch-controlfields.html#version). We had this in #527. But issue here is different because it's about package file names. Naming standard for this aspect is at https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names .

[yassingh]

+1 with @fossam
There was an issue because of using underscore in "version" string of debian packages.
I hope that @basepi is also referring to this issue only.

Moreover, even the current debian builds are named in the same way as I am proposing ( debian build names are also using dashes here https://github.com/hubblestack/hubble/releases/tag/v2.4.7 ).

Earlier I used to rename the debain builds while uploading them.
With this PR, the debian builds will be renamed as soon as they are created inside the docker container.
So, this path change has already been tested by all of us.

[basepi]

Ah, understood. Thanks for the explanation!