Support for projects #545
Merged
Support for projects #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
reviewed
Sep 25, 2019
| return this; | ||
| } | ||
|
|
||
| private void edit(String key, Object value) throws IOException { |
There was a problem hiding this comment.
What do you think of the builder/updater style instead?
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHRelease.java
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHReleaseBuilder.java
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GHReleaseUpdater.java
It would reduce round trips but would add more code.
I don't have a strong opinion. The project doesn't seem to have one particular style it uses, I'd like to move toward a more consistent style. I'm wondering what you think.
(Maybe @kohsuke can comment as well if he's around.)
bitwiseman
reviewed
Oct 4, 2019
| /** | ||
| * Returns the projects for this organization. | ||
| * @param status The status filter (all, open or closed). | ||
| */ |
There was a problem hiding this comment.
Suggested change
| */ | |
| */ | |
| @Preview @Deprectated |
Fixes issue hub4j#425
…cts, columns and cards
bitwiseman
force-pushed
the
issue_425_projects_columns_cards
branch
from
ef7e4fb
to
d787359
Compare
bitwiseman
force-pushed
the
issue_425_projects_columns_cards
branch
from
d787359
to
5cc88a0
Compare
Need to mock raw.githubusercontent.com to make this work
bitwiseman
force-pushed
the
issue_425_projects_columns_cards
branch
from
40fe212
to
20cfb26
Compare
bitwiseman
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of #483 where project columns and cards have been added, as well as some tests