Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add latest release #343

Merged
merged 4 commits into from
Sep 8, 2017
Merged

add latest release #343

merged 4 commits into from
Sep 8, 2017

Conversation

kamontat
Copy link
Contributor

I already add the latest release, so please add to master and update version so that I can use in my project
Fix #341

PS I don't know how to push my fixed module to the maven server so, please. @emlagowski

Thank you

@Shredder121
Copy link
Contributor

It seems the indentation is off though.
And also, would a test be good for this feature?
(I'm not a member, so don't take my word on this)

@emlagowski
Copy link

@kamontat I'm also not a member.

@Shredder121 taking the opportunity, do you know how to run tests locally if I have no access to repositories and organisations that are referenced from the unit tests?

@KostyaSha
Copy link
Contributor

You can read test code, it uses file with local configuration. Create additional account and run using it.

@@ -298,6 +298,10 @@ public GHRef createRef(String name, String sha) throws IOException {
public List<GHRelease> getReleases() throws IOException {
return listReleases().asList();
}

public GHRelease latestRelease() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be getLatestRelease,
fix indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, Thank you

Copy link
Contributor

@KostyaSha KostyaSha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be getLatestRelease,
fix indentation

@emlagowski
Copy link

@KostyaSha I know that, but it still fails. Is there any list of what scopes an access token needs to pass the tests?

@kamontat
Copy link
Contributor Author

@Shredder121 I already testing on it in my own repository, so I sure it's work

but I don't push my test up because I test by using my own repository.

@kohsuke kohsuke merged commit 2e2813f into hub4j:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I get Latest Release of Repository?
5 participants