GitHub API have changed the semantics of /user/repos API #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kohsuke Kawaguchi » github-api #358 SUCCESS |
lucamilanesio
force-pushed
the
ghmyself-getrepositories-semantic-change
branch
from
641e601
to
e30962f
Compare
lucamilanesio
changed the title
|
Kohsuke Kawaguchi » github-api #359 SUCCESS |
|
@kohsuke this patch is very urgent since GitHub API have been rolled out two days ago with the new semantics :-( Can you have a look today if makes sense? |
| * Type of repositories returned during listing. | ||
| */ | ||
| public enum RepositoryType { | ||
| All, // All public and private repositories that current user has access or collaborates to |
There was a problem hiding this comment.
Enum should be CAPITAL_CASED
you can rewrite toString() method if want to change string representation
There was a problem hiding this comment.
Done. I've decided to use name().toLowerCase() instead of relying on the toString() override.
It seems that since a couple of days (or weeks?) the /user/repos is returning ALL the repositories that the user has access or collaborates to whilst previously were only the ones that belong to him. JavaDoc updated in order to avoid getting unwanted results and introduced as well the possibility to filter a specific type of repository to be returned: - All (the GitHub's default) - Owner (the user's repos) - Public / Private (public or private repos) - Member (the user collaborates to)
lucamilanesio
force-pushed
the
ghmyself-getrepositories-semantic-change
branch
from
e30962f
to
b0d1eac
Compare
|
Kohsuke Kawaguchi » github-api #360 SUCCESS |
|
@lanwen all changes done, thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that since a couple of days (or weeks?) the /user/repos is returning
ALL the repositories that the user has access or collaborates to whilst previously
were only the ones that belong to him.