Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we refresh the PRs with the PR API (and not the issues API) #1810

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Make sure we refresh the PRs with the PR API (and not the issues API) #1810

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5033848
Make sure we refresh the PRs with the PR API (and not the issues API)
gsmet Mar 9, 2024
8ba98b4
Merge branch 'main' into refresh-prs-with-pr-api
bitwiseman Mar 11, 2024
1f66efa
Update GHPullRequestTest.java
bitwiseman Mar 11, 2024
16907f0
Update GHPullRequestTest.java
bitwiseman Mar 11, 2024
cfffe16
Update GHPullRequestTest.java
bitwiseman Mar 11, 2024
8bc0bfc
Update GHPullRequestTest.java
bitwiseman Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update GHPullRequestTest.java
  • Loading branch information
@bitwiseman
bitwiseman authored Mar 11, 2024
commit 8bc0bfc5d9ac350c3fa181c5fe08f647f4eb7f0e
6 changes: 3 additions & 3 deletions src/test/java/org/kohsuke/github/GHPullRequestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,14 +917,14 @@ public void reactions() throws Exception {
public void refreshFromSearchResults() throws Exception {
// To re-record, uncomment the Thread.sleep() calls below
snapshotNotAllowed();

String prName = "refreshFromSearchResults";
GHRepository repository = getRepository();

repository.createPullRequest(prName, "test/stable", "main", "## test");

// we need to wait a bit for the pull request to be indexed by GitHub
//Thread.sleep(2000);
// Thread.sleep(2000);

GHPullRequest pullRequestFromSearchResults = repository.searchPullRequests()
.isOpen()
Expand All @@ -936,7 +936,7 @@ public void refreshFromSearchResults() throws Exception {
pullRequestFromSearchResults.getMergeableState();

// wait a bit for the mergeable state to get populated
//Thread.sleep(5000);
// Thread.sleep(5000);

assertThat("Pull request is supposed to have been refreshed and have a mergeable state",
pullRequestFromSearchResults.getMergeableState(),
Expand Down