Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put mockito in the test scope. #139

Merged
merged 1 commit into from
Dec 19, 2014

Conversation

farmdawgnation
Copy link
Contributor

I was having issues in a downstream project from github-api where mockito was appearing on the classpath where it shouldn't. I ran some dependency analysis and found that the inclusion was because of its mention in github-api without the test scope designation.

@buildhive
Copy link

Kohsuke Kawaguchi » github-api #249 SUCCESS
This pull request looks good
(what's this?)

@rtyley
Copy link
Contributor

rtyley commented Dec 2, 2014

Looks like this is a duplicate of #140 ? Entirely valid issue though!

suryagaddipati added a commit that referenced this pull request Dec 19, 2014
@suryagaddipati suryagaddipati merged commit e15f7a5 into hub4j:master Dec 19, 2014
@farmdawgnation farmdawgnation deleted the mocking-scope branch December 19, 2014 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants