Skip to content

Conversation

jetersen
Copy link
Contributor

@jetersen jetersen commented Jan 18, 2022

Description

add org filter to repository search

https://docs.github.com/en/search-github/searching-on-github/searching-for-repositories#search-within-a-users-or-organizations-repositories

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jetersen
Please complete the PR checklist (updated the PR description to include it).

In particular, add this parameter to an existing test or create new tests for it.

@jetersen
Copy link
Contributor Author

jetersen commented Jan 29, 2022

@bitwiseman I couldn't find any existing tests that used the repository search feature 😓

At least no test file called GHRepositorySearchBuilderTest.java

@jetersen jetersen changed the title add org to repository search add org filter to repository search Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #1355 (8de03e2) into main (9b164ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1355   +/-   ##
=========================================
  Coverage     78.10%   78.10%           
- Complexity     2045     2046    +1     
=========================================
  Files           200      200           
  Lines          6270     6271    +1     
  Branches        355      355           
=========================================
+ Hits           4897     4898    +1     
  Misses         1165     1165           
  Partials        208      208           
Impacted Files Coverage Δ
.../org/kohsuke/github/GHRepositorySearchBuilder.java 82.05% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b164ca...8de03e2. Read the comment docs.

@bitwiseman
Copy link
Member

@jetersen
Take a look at #1188

@bitwiseman
Copy link
Member

@jetersen
Do you have time to update this PR? I'll be doing a release in the next few days. This just needs test coverage.

@jetersen
Copy link
Contributor Author

@bitwiseman test are added 😅

@bitwiseman bitwiseman self-requested a review February 15, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants