Skip to content

Commit

Permalink
[MINOR][ML] Remove unnecessary default value setting for evaluators.
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?
Remove unnecessary default value setting for all evaluators, as we have set them in corresponding _HasXXX_ base classes.

## How was this patch tested?
Existing tests.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#19262 from yanboliang/evaluation.
  • Loading branch information
yanboliang committed Sep 19, 2017
1 parent 8319432 commit 2f96242
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions python/pyspark/ml/evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ def __init__(self, rawPredictionCol="rawPrediction", labelCol="label",
super(BinaryClassificationEvaluator, self).__init__()
self._java_obj = self._new_java_obj(
"org.apache.spark.ml.evaluation.BinaryClassificationEvaluator", self.uid)
self._setDefault(rawPredictionCol="rawPrediction", labelCol="label",
metricName="areaUnderROC")
self._setDefault(metricName="areaUnderROC")
kwargs = self._input_kwargs
self._set(**kwargs)

Expand Down Expand Up @@ -224,8 +223,7 @@ def __init__(self, predictionCol="prediction", labelCol="label",
super(RegressionEvaluator, self).__init__()
self._java_obj = self._new_java_obj(
"org.apache.spark.ml.evaluation.RegressionEvaluator", self.uid)
self._setDefault(predictionCol="prediction", labelCol="label",
metricName="rmse")
self._setDefault(metricName="rmse")
kwargs = self._input_kwargs
self._set(**kwargs)

Expand Down Expand Up @@ -297,8 +295,7 @@ def __init__(self, predictionCol="prediction", labelCol="label",
super(MulticlassClassificationEvaluator, self).__init__()
self._java_obj = self._new_java_obj(
"org.apache.spark.ml.evaluation.MulticlassClassificationEvaluator", self.uid)
self._setDefault(predictionCol="prediction", labelCol="label",
metricName="f1")
self._setDefault(metricName="f1")
kwargs = self._input_kwargs
self._set(**kwargs)

Expand Down

0 comments on commit 2f96242

Please sign in to comment.