Disallow root script run #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
huan
requested changes
Oct 22, 2023
|
Thanks. I just made the changes requested. |
fix shell return code
|
It seems that there's a problem when publishing the image to the docker hub: https://github.com/huan/docker-wechat/actions/runs/6606361107/job/17942485588#step:5:294 @DE0CH Could you please take a look at it? Thank you very much! |
|
Yep. #210. I actually ran into this problem when debugging, but seeing that the docker image somehow was built and published to the docker hub I thought it didn't need fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a check to stop the script if the user is root. Also, I hid an environment variable
ALLOWROOTwhich if set to 1 will allow the script to run if the user wants to run it as root for whatever reason.This would avoid numerous issues with
~/DoChatbecoming owned by root causing permission denided issues (such as in #165 and #178).Also, I got rid of the warning message of
lshw -C displaywhich, if not run with sudo, confusingly prints outWARNING: you should run this program as super-user., which can mislead people (including me) to run the script with sudo