Skip to content

Conversation

LPardue
Copy link
Contributor

@LPardue LPardue commented Sep 1, 2025

Taking the suggestion from #3231

Closes #3231

Upload-Complete: ?1
Upload-Offset: 25000000
Content-Length: 25000000
Upload-Offset: 46913578
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make sure that the final completed length is 1234567890? So each chunk can be 1200000000, 34000000, 560000, 7800, 90?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of the examples was that they are fairly isolated from each other. Even prior to the change to use larger numbers, in https://www.ietf.org/archive/id/draft-ietf-httpbis-resumable-upload-09.html#section-4.4.3 the appends result in an object that has a total length of 300 bytes, which doesn't correlate to any upload length in other examples.

Furthermore, I'd prefer to keep examples concise. Adding multiple append operations that don't do much beyond using a different size increases the length of example and might add more source of confusion. I created #3250 that highlights this via reuse of the same URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I wasn't suggesting adding more appends to the example, I was just thinking 46913578 kind of loses the benefit of the easily recognizable number. If offset is 1230000000 and length is 4567890, it's obvious that they add up together as 1234567890

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I undestand now, I can do that

Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the small comment from Guoye is integrated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Large numbers in examples

3 participants