Skip to content

Talk about exceptions to storing and updating headers - #337

Merged
royfielding merged 16 commits into
masterfrom
mnot-165
May 25, 2020
Merged

Talk about exceptions to storing and updating headers#337
royfielding merged 16 commits into
masterfrom
mnot-165

Conversation

@mnot

@mnot mnot commented Mar 19, 2020

Copy link
Copy Markdown
Member

Fixes #165

@mnot mnot mentioned this pull request Mar 19, 2020
3 tasks

@royfielding royfielding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a bit of "headers" usage here -- was it written before the editorial changes?

I'd rather it be consistent regarding "header fields" or just "fields" before applying.

@mnot

mnot commented Apr 28, 2020

Copy link
Copy Markdown
Member Author

Updated to use 'fields' as appropriate.

This test relies upon the understanding that Connection operates only on headers, not trailers; 2616 seems to support that.

If that's the case, I think we need to make the appropriate changes in Messaging; @royfielding should we do that here, or in a separate issue first?

@royfielding royfielding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first MUST is right, but I believe the last three cases apply to both header and trailer fields. IOW, the names in Connection apply to trailers being forwarded as well.

@royfielding

Copy link
Copy Markdown
Member

The reason

The first MUST is right, but I believe the last three cases apply to both header and trailer fields. IOW, the names in Connection apply to trailers being forwarded as well.

The reason being that 2616 assumes the trailers would be merged as header fields (or simply dropped) prior to forwarding the message.

@mnot

mnot commented May 5, 2020

Copy link
Copy Markdown
Member Author

@royfielding that makes sense, although I suspect even fewer implementations are going to be doing that; might be worth reinforcing in Semantics?

In any case, please review.

@mnot
mnot requested a review from royfielding May 5, 2020 07:39
Comment thread draft-ietf-httpbis-cache-latest.xml Outdated
Comment on lines +405 to +409
<li>Header fields that are specific to the connection they occur
&MUST-NOT; be stored. Effectively, this is limited to Proxy-Authenticate
<xref target="field.proxy-authenticate"/> and Proxy-Authorization <xref
target="field.proxy-authorization">, since new fields are
discouraged from being tied to a specific connection.</li>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is dependent upon the resolution of #331, which may not go this way.

@reschke reschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comments; also need change log entry; I can update the PR...)

Comment thread draft-ietf-httpbis-cache-latest.xml
Comment thread draft-ietf-httpbis-cache-latest.xml
@mnot

mnot commented May 20, 2020

Copy link
Copy Markdown
Member Author

OK, I think this is good to go with that last change.

@royfielding could you please review?

@royfielding royfielding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this is not just talking about caches storing fields now. The changes to messaging are reverting a longstanding consensus (and demonstrated practice) that there are no "hop-by-hop" headers other than Connection and those listed in Connection. The listed fields can't be simply dropped - they must be processed according to their semantics, which drops them when applicable.

@mnot

mnot commented May 21, 2020

Copy link
Copy Markdown
Member Author

@royfielding see update

@mnot
mnot requested review from reschke and royfielding May 21, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Updating stored headers

3 participants