Skip to content

Conversation

@geoand
Copy link
Contributor

@geoand geoand commented Dec 24, 2021

Eclipse Vert.x is one of the best ways to build Reactive applications on the JVM, so this Pull Request is intended to bring out of the box support for it's Http and Web clients.

Furthermore, this change will enable to instrumentation of the Reactive REST Client of Quarkus as it's build on top of the Vert.x Http Client.

@CLAassistant
Copy link

CLAassistant commented Dec 24, 2021

CLA assistant check
All committers have signed the CLA.

@pimterry
Copy link
Member

Amazing! This is great, thanks so much. I'll merge this now.

For HTTP Toolkit usage, I'll include this in the next server release, probably next week, and then this should work out of the box, for both attach & intercepted terminal usage.

In the meantime, if you'd like you can immediately grab and use the built JAR from releases after the build completes, and swap that in to your local install to get this working. You just need to replace HTTP Toolkit's own bundled agent with that version. You can see the path to the bundled agent on your machine by looking at the JAVA_TOOL_OPTIONS env var in an intercepted terminal. If you replace that, everything should start working immediately.

In case you're not aware, HTTP Toolkit Pro is totally free for contributors. I've set up a Pro account for the email from your commits, let me know if you'd prefer a different email instead. To use that, just click 'Get Pro', then 'Log into existing account' in the app, and enter your email.

@pimterry pimterry merged commit 19fd369 into httptoolkit:main Dec 29, 2021
@geoand
Copy link
Contributor Author

geoand commented Dec 29, 2021

That's awesome, thanks a lot!

I'll make good use of it ☺️

@geoand geoand deleted the vertx-client branch December 29, 2021 17:22
@famod
Copy link

famod commented Dec 29, 2021

Thanks @geoand for making me aware of this nice toolkit! (yes, I've been stalking you 😄)

@geoand
Copy link
Contributor Author

geoand commented Dec 29, 2021 via email

@maxandersen
Copy link
Contributor

Vertx/quarkus and java 17 support - can't wait for the next release :)

@pimterry
Copy link
Member

pimterry commented Jan 4, 2022

This is now live in the latest HTTP Toolkit server release!

HTTP Toolkit will update in the background next time it's opened, and everything should work correctly on the subsequent run. Thanks again for the PR 👍

@geoand
Copy link
Contributor Author

geoand commented Jan 4, 2022

Awesome, thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants