-
Notifications
You must be signed in to change notification settings - Fork 22
Introduce support for Vert.x HttpClient and WebClient #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Amazing! This is great, thanks so much. I'll merge this now. For HTTP Toolkit usage, I'll include this in the next server release, probably next week, and then this should work out of the box, for both attach & intercepted terminal usage. In the meantime, if you'd like you can immediately grab and use the built JAR from releases after the build completes, and swap that in to your local install to get this working. You just need to replace HTTP Toolkit's own bundled agent with that version. You can see the path to the bundled agent on your machine by looking at the JAVA_TOOL_OPTIONS env var in an intercepted terminal. If you replace that, everything should start working immediately. In case you're not aware, HTTP Toolkit Pro is totally free for contributors. I've set up a Pro account for the email from your commits, let me know if you'd prefer a different email instead. To use that, just click 'Get Pro', then 'Log into existing account' in the app, and enter your email. |
|
That's awesome, thanks a lot! I'll make good use of it |
|
Thanks @geoand for making me aware of this nice toolkit! (yes, I've been stalking you 😄) |
|
😝😝😝
It was @maxandersen that made me aware of it actually
…On Wed, Dec 29, 2021, 20:10 Falko Modler ***@***.***> wrote:
Thanks @geoand <https://github.com/geoand> for making me aware of this
nice toolkit! (yes, I've been stalking you 😄)
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMDP7BQ2XBPZCEDDTRKS3UTNFJZANCNFSM5KW7WMWA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Vertx/quarkus and java 17 support - can't wait for the next release :) |
|
This is now live in the latest HTTP Toolkit server release! HTTP Toolkit will update in the background next time it's opened, and everything should work correctly on the subsequent run. Thanks again for the PR 👍 |
|
Awesome, thanks for the heads up! |
Eclipse Vert.x is one of the best ways to build Reactive applications on the JVM, so this Pull Request is intended to bring out of the box support for it's Http and Web clients.
Furthermore, this change will enable to instrumentation of the Reactive REST Client of Quarkus as it's build on top of the Vert.x Http Client.