Skip to content

Add automatic theme (syncs with system settings) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

Bleuzen
Copy link
Contributor

@Bleuzen Bleuzen commented Sep 12, 2023

Hi :)
This adds an option to follow the systems color theme. If theme is changed in system settings, HTTP Toolkit will automatically adapt (if enabled).

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@pimterry
Copy link
Member

pimterry commented Sep 13, 2023

Hi @Bleuzen, thanks for this! Great idea.

The underlying model all looks great to me, but I'm not totally sure about the UX. Was there a reason you didn't add this as another tab in the theme options? Most theme pickers I've seen elsewhere use Auto/Dark/Light for example. I think that might be a little clearer and more intuitive for users coming from other tools.

Firefox for example (with a system dark mode default):

Firefox showing auto/light/dark buttons

What do you think?

@Bleuzen
Copy link
Contributor Author

Bleuzen commented Sep 15, 2023

Was there a reason you didn't add this as another tab in the theme options?

Was, yeah. Had it as tab first but it was buggy sometimes under circumstances.
Note: I usually don't work with some stuff used in httptoolkit, so I probably just made a weird mistake with mobx or something.

Anyway, gave it another try and it works this time. Pushed now.

@Bleuzen
Copy link
Contributor Author

Bleuzen commented Sep 15, 2023

I'm not perfectly happy with the icon yet, didn't find a simple one for automatic and adjust is already used for the high contrast theme, so went with magic for now.
@pimterry if you have a better idea, go ahead.

@pimterry pimterry merged commit 504213c into httptoolkit:main Sep 18, 2023
@pimterry
Copy link
Member

Great stuff, thanks @Bleuzen! Looks perfect to me 👍

By the way, in case you're not aware, HTTP Toolkit Pro is totally free for contributors. If you're interested, just let me know your email address (here or send me a message at tim @ httptoolkit.com) and I'll set you up.

@Bleuzen Bleuzen deleted the add-auto-theme branch September 21, 2023 11:06
@Bleuzen Bleuzen restored the add-auto-theme branch September 21, 2023 11:06
@Bleuzen Bleuzen deleted the add-auto-theme branch September 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants