[pull] master from cloudflare:master#296
Open
pull[bot] wants to merge 84 commits intohttpsgithu:masterfrom
Open
[pull] master from cloudflare:master#296pull[bot] wants to merge 84 commits intohttpsgithu:masterfrom
pull[bot] wants to merge 84 commits intohttpsgithu:masterfrom
Conversation
…e confirm (#2028) * add NotADirectoryError for sites and add loop to confirm function in interactive * Update src/sites/mod.rs Co-authored-by: MrBBot <me@mrbbot.dev> Co-authored-by: Mengqi Chen <mengqi@cloudflare.com> Co-authored-by: MrBBot <me@mrbbot.dev>
* add info when dev fails * Update src/commands/whoami.rs Co-authored-by: Sunil Pai <threepointone@gmail.com> * fix wording * add semicolon Co-authored-by: Sunil Pai <threepointone@gmail.com>
* Move TOML table fields come later than other fields * Format code Co-authored-by: Sunil Pai <threepointone@gmail.com>
…2064) * add env var for endpoint url * add tests and update env var * simplify match statements * update env var naming
* add back in value names for rename and transfer class lost during migration to structopt * Implement tagged adhoc migrations, and tagged migrations in wrangler.toml
- Add --inspect flag - Proxy between chrome and remote websocket - Prompt the user to manually open chrome://inspect - Avoid "error: reconnecting" by sending a startup request This code should hopefully go away altogether eventually when ObsidianMinor implements warmup requests coming from the edge server instead.
This avoids changing the state of the worker the first time it's run.
* Integrates the OAuth flow to Wrangler login * Adds token revokation with Wrangler logout
Example usage:
```
$ RUST_BACKTRACE=1 wrangler dev --inspect
Error: missing field `prewarm` at line 1 column 627
Stack backtrace:
0: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/core/src/result.rs:1675:27
1: wrangler::commands::dev::edge::setup::Session::new
at /home/jnelson/src/wrangler/src/commands/dev/edge/setup.rs:103:48
2: wrangler::commands::dev::edge::dev_once
at /home/jnelson/src/wrangler/src/commands/dev/edge/mod.rs:90:19
3: wrangler::commands::dev::edge::dev
at /home/jnelson/src/wrangler/src/commands/dev/edge/mod.rs:46:21
4: wrangler::commands::dev::dev
at /home/jnelson/src/wrangler/src/commands/dev/mod.rs:75:20
5: wrangler::cli::dev::dev
at /home/jnelson/src/wrangler/src/cli/dev.rs:40:5
6: wrangler::run
at /home/jnelson/src/wrangler/src/main.rs:107:14
7: wrangler::main_handling_errors
at /home/jnelson/src/wrangler/src/main.rs:55:5
8: wrangler::main
at /home/jnelson/src/wrangler/src/main.rs:21:23
9: core::ops::function::FnOnce::call_once
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/core/src/ops/function.rs:227:5
10: std::sys_common::backtrace::__rust_begin_short_backtrace
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/sys_common/backtrace.rs:125:18
11: std::rt::lang_start::{{closure}}
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/rt.rs:49:18
12: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/core/src/ops/function.rs:259:13
std::panicking::try::do_call
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/panicking.rs:401:40
std::panicking::try
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/panicking.rs:365:19
std::panic::catch_unwind
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/panic.rs:434:14
std::rt::lang_start_internal
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/rt.rs:34:21
13: std::rt::lang_start
at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/rt.rs:48:5
14: main
15: __libc_start_main
16: _start
```
Co-authored-by: Sunil Pai <threepointone@gmail.com>
* fix: remove panic when send fails, log error instead * fix: address pr feedback, add error message to log * chore: update other send failures to log errors
Note that this links to a documentation page which is being added in: cloudflare/cloudflare-docs#2289
Co-authored-by: Joshua Nelson <jnelson@cloudflare.com>
* revert watch_for_changes * update to show an error message * add process exit * continue watching if there's a syntax error for wrangler dev * typo Co-authored-by: ocs <46542932+ocsfrank@users.noreply.github.com>
* 1.19.3 (release) 1.19.3 point release, including wrangler dev --inspect, oauth integration, tagged DO migrations, and more * Apply suggestions from code review Co-authored-by: Sunil Pai <threepointone@gmail.com> Co-authored-by: Sunil Pai <threepointone@gmail.com>
Previously, running it with no account_id and no config in ~/.wrangler would give an error: ``` Error: config path does not exist /home/jnelson/.wrangler/config/default.toml. Try running `wrangler login` or `wrangler config` ``` This is not technically a regression from loading account_id lazily, because in wrangler 1.17 it would just error earlier that account_id was required: ``` 🕵️ You can find your account_id in the right sidebar of your account's Workers page Error: field `account_id` is required to deploy to workers.dev ``` However, it seems odd that you'd have to have an account to run an unauthenticated preview. This changes wrangler to only require an account_id or config file if you're actually deploying your site. This also changes the tests not to expect that wrangler requires an account_id just to load the available deployments.
* [sites] Don't delete unused assets We have a consistency issue when after uploading a new site, it takes a while for the worker to propagate, so incoming requests will try to fetch older assets, and 404. This isn't an issue just with us, it's a common scenario. besides, there's no real reason to delete older assets, we don't have limits on how many keys we use (https://developers.cloudflare.com/workers/platform/limits#kv-limits). Maybe someone could write a script that does a cleanup, but there's no reson to delete previous deployments assets immediately. (This matches Pages behaviour too). This PR removes the functionality where we delete unused assets on fresh uploads. * Update npm-shrinkwrap.json via `npm audit fix` * lint fix
* Allow host to be passed while authenticated and add unauthenticated arg for dev * Changed authenticated host warning to appear only when session host and provided host differ Co-authored-by: Sunil Pai <spai@cloudflare.com>
* Only warn about compatibility dates on publish and dev * Added compatability date warning to dev Co-authored-by: jspspike <jspspike@gmail.com>
See #2108: Node 17 uses openssl 3 by default, which is not compatible with webpack 4. This change adds a check to see if the user is running node 17, and if they are, we add the appropriate flag to the call to node (https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V17.md#openssl-30)
Without this, the error message would literally be 'Your token has
status "{}"' with curly braces in it instead of the token status.
This code was doing two inconsistent things with the bail macro args:
the one in delete.rs used single `{` assuming the string would *not* get
put into std::fmt, while the one in put.rs used double `{{` assuming
that std::fmt *would* get applied to it.
This change closes the inconsistency and makes room for the bail macro
to catch issues like this statically in a future version.
* Improve version checking * pass fmt check Co-authored-by: Sunil Pai <spai@cloudflare.com>
Co-authored-by: jjohnson <jjohnson@cloudflare.com>
Co-authored-by: Jacob M-G Evans <27247160+JacobMGEvans@users.noreply.github.com>
* chore: remove reporter As part of the deprecation efforts, removed reporter as we will no longer be supporting Wrangler 1
This release is part of initial deprecation efforts and includes removing reporter functionality
* Update Wrangler2 repo * Update Wrangler1 repo links * Undo formatting 🤦 * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: MrBBot <bcoll@cloudflare.com>
* chore: deprecation Internal ticket: Messaging for Wrangler1 deprecation * Deprecated wording over Deprecation * Change messaging to the approved copy for all deprecation locations * message include npm & cargo paths with Docs reference
Co-authored-by: Somhairle MacLeòid <samuel@macleod.space>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )