feat: Add auto dark mode theme according to OS setting #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeriopvl
reviewed
Jul 19, 2021
| @@ -31,7 +31,7 @@ | |||
| } | |||
|
|
|||
| #carbonads a { | |||
| color: inherit; | |||
| color: var(--text-color-light); | |||
| text-decoration: none; | |||
| } | |||
| #carbonads a:hover { | |||
There was a problem hiding this comment.
Hey 👋
This one needs to be changed as well, otherwise on hover the font will be invisible.
Used default page color which made text white on dark mode
|
@rogeriopvl just updated |
|
🎉 Thanks! |
|
@all-contributors add @dcruz for code, design and a11y |
|
I've put up a pull request to add @dcruz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dark mode theme that automatically triggers if the users' OS triggers the dark mode on media query
prefers-color-scheme