Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-http4s-org to 0.17.0 in series/0.23 #867

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

http4s-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.http4s:sbt-http4s-org from 0.16.3 to 0.17.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.http4s", artifactId = "sbt-http4s-org" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s", artifactId = "sbt-http4s-org" }
}]
labels: sbt-plugin-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, commit-count:1

@mergify mergify bot added series/0.23 PRs targeting 0.23.x dependencies Dependency updates labels Apr 25, 2024
@danicheg danicheg force-pushed the update/series/0.23/sbt-http4s-org-0.17.0 branch from 3ee6451 to cd75581 Compare April 26, 2024 06:07
Comment on lines -47 to -48
override def drain(lastHandledOutboundStream: Int, reason: Http2SessionException): Future[Unit] =
???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That finally happened: code formatted by Scalafmt fails checks of Scalafix.

[error] /home/runner/work/blaze/blaze/http/src/test/scala/org/http4s/blaze/http/http2/mocks/MockTools.scala:60:99: error: illegal start of simple expression
[error]   override def invokeGoAway(lastHandledOutboundStream: Int, reason: Http2SessionException): Unit =
[error]                                                                                                   ^
[error] /home/runner/work/blaze/blaze/http/src/test/scala/org/http4s/blaze/http/http2/mocks/MockStreamManager.scala:47:100: error: illegal start of simple expression
[error]   override def drain(lastHandledOutboundStream: Int, reason: Http2SessionException): Future[Unit] =
[error]

@danicheg danicheg merged commit f0ff468 into series/0.23 Apr 26, 2024
8 checks passed
@danicheg danicheg deleted the update/series/0.23/sbt-http4s-org-0.17.0 branch April 26, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant