Skip to content
This repository was archived by the owner on Jun 21, 2020. It is now read-only.

Rename Fut to ResponseFuture #29

Merged
merged 3 commits into from
May 10, 2019

Conversation

prasannavl
Copy link
Contributor

Description

Resolves #24

Motivation and Context

Currently, the associated params of HttpService are ConnectionFuture which corresponds to connect, and the Fut which corresponds to respond.

I think it'd be better to call this ResponseFuture such that it maintains parity.

connect -> ConnectionFuture
respond -> ResponseFuture

rather than the Fut that isn't really informative or intuitive.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prasannavl prasannavl force-pushed the 2019_05_fut_to_responsefut branch from 59c0aa4 to 80e4e55 Compare May 9, 2019 14:22
@secretfader
Copy link
Contributor

You'll need to change the associated type in http-service-mock to satisfy CI, but other than that this change gets a 👍 from me. (It's a tiny modification with potentially huge positive impact.)

@prasannavl prasannavl force-pushed the 2019_05_fut_to_responsefut branch from 7f08c08 to d75ab52 Compare May 9, 2019 15:15
@prasannavl
Copy link
Contributor Author

Yup. Was just working on it. This should do it

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@yoshuawuyts yoshuawuyts merged commit 6b9b298 into http-rs:master May 10, 2019
@prasannavl prasannavl deleted the 2019_05_fut_to_responsefut branch May 19, 2019 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Fut into ResponseFuture
3 participants