http types and async-h1 for 2.0.0 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
commented
May 22, 2020
| @@ -38,6 +38,8 @@ pub type Request = http_types::Request; | |||
| /// An HTTP Response type with a streaming body. | |||
| pub type Response = http_types::Response; | |||
|
|
|||
| pub use http_types; | |||
There was a problem hiding this comment.
not sure if I should remove this — my original plan was to remove the direct dependency from surf and only use the re-export from http-client to make updates easier in the future, but that change was far too sprawling
There was a problem hiding this comment.
That makes sense. Happy to keep things as they are now. Something we should still explore is whether we can deprecate http-client as well.
dignifiedquire
approved these changes
May 25, 2020
yoshuawuyts
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.