Skip to content

feat: implement client for async-h1 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2020
Merged

feat: implement client for async-h1 #22

merged 2 commits into from
Apr 11, 2020

Conversation

@dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Mar 2, 2020 •
edited by yoshuawuyts
Loading

  • Switches to uses http-types
  • Implement client using async-h1
  • Currently this breaks the isahc client, as isahc::Body is not Sync

@dignifiedquire dignifiedquire mentioned this pull request Mar 2, 2020
Merged
@yoshuawuyts yoshuawuyts mentioned this pull request Mar 2, 2020
Closed
yoshuawuyts
yoshuawuyts reviewed Mar 2, 2020
View reviewed changes
src/h1.rs

client::connect(stream, req).await
}
_ => unreachable!(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should return an error here instead.

Suggested change
_ => unreachable!(),
_ => http_types::bail!("Unsupported protocol prefix"),

@goto-bus-stop
Copy link
Member

isahc 0.9 will make isahc::Body impl Sync 🎉 sagebind/isahc@7c3955f

@yoshuawuyts
Copy link
Member

And it's been merged! sagebind/isahc#172 (comment)

@dignifiedquire
Copy link
Member Author

Unfortunately that was not enough. isahc::Body only implements AsyncRead, whereas http-types::Body requires AsyncBufRead to be implemented.

Thoughts @yoshuawuyts

@dignifiedquire
Copy link
Member Author

Figured it out, using async_std::io::BufReader it now works.

@yoshuawuyts yoshuawuyts merged commit 27987ed into http-rs:master Apr 11, 2020
@goto-bus-stop goto-bus-stop mentioned this pull request Apr 22, 2020
Closed
@strohel strohel mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dignifiedquire @goto-bus-stop @yoshuawuyts