Skip to content

feat: expose http(s).request lookup option and add types #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: expose http(s).request lookup option and add types #1644

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39d453a
feat: add types
aadi-paypay Aug 4, 2023
17b648f
feat: add lookup option
aadi-paypay Aug 4, 2023
99674b7
fix: node v
aadi-paypay Aug 4, 2023
c7fe0c1
fix: typeof
aadi-paypay Aug 4, 2023
db16bdc
fix: lookup type
aadi-paypay Aug 4, 2023
54110c9
fix: remove node:
aadi-paypay Aug 4, 2023
82d2ccf
fix: revert package.json changes
aadi-paypay Aug 4, 2023
c68565e
docs: add to readme options
aadi-paypay Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: lookup type
  • Loading branch information
@aadi-paypay
aadi-paypay committed Aug 4, 2023
commit db16bdcb564006cd47a1333807769b2fee414ee0
3 changes: 2 additions & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import * as events from "events";
import * as url from "url";
import * as stream from "stream";
import * as dns from "dns";
import { LookupFunction } from 'node:net';

interface ProxyTargetDetailed {
host: string;
Expand Down Expand Up @@ -191,7 +192,7 @@ declare namespace Server {
/** Buffer */
buffer?: stream.Stream | undefined;
/** Custom lookup to pass to http(s).request */
lookup?: typeof dns.lookup | undefined;
lookup?: LookupFunction | undefined;
}

type StartCallback<TIncomingMessage = http.IncomingMessage, TServerResponse = http.ServerResponse> = (
Expand Down