Skip to content

WIP: Fixes for 775 & 959, double slashes in query params when ignorePath: true #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Fixes for 775 & 959, double slashes in query params when ignorePath: true #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/lib-http-proxy-common-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,30 @@ describe('lib/http-proxy/common.js', function () {
expect(outgoing.path).to.eql('/some/crazy/path/whoooo');
});

// Bugfix validation: 775, 959
it.only('should ignore the path of the `req.url` passed in but use the target path with two unencoded urls as query parameters', function () {
var outgoing = {};
var myEndpoint = 'https://whatever.com/some/crazy/path/whoooo?redirectTo=https://example.com&secondaryRedirect=https://test.com';
common.setupOutgoing(outgoing, {
target: url.parse(myEndpoint),
ignorePath: true
}, { url: '/more/crazy/pathness' });

expect(outgoing.path).to.eql('/some/crazy/path/whoooo?redirectTo=https://example.com&secondaryRedirect=https://test.com');
});

// Bugfix validation: 775, 959
it.only('should ignore the path of the `req.url` passed in but use the target path with two unencoded slashes in a query parameter', function () {
var outgoing = {};
var myEndpoint = 'https://whatever.com/some/crazy/path/whoooo?key=//myValue';
common.setupOutgoing(outgoing, {
target: url.parse(myEndpoint),
ignorePath: true
}, { url: '/more/crazy/pathness' });

expect(outgoing.path).to.eql('/some/crazy/path/whoooo?key=//myValue');
});

it('and prependPath: false, it should ignore path of target and incoming request', function () {
var outgoing = {};
var myEndpoint = 'https://whatever.com/some/crazy/path/whoooo';
Expand Down